fix(providers): use mapped Sonnet model for connection tests - #663
Open
NickyLam wants to merge 1 commit into
Open
fix(providers): use mapped Sonnet model for connection tests#663NickyLam wants to merge 1 commit into
NickyLam wants to merge 1 commit into
Conversation
Connection tests previously preferred a hidden preset catalog alias (for example "sonnet") over the user's mapped Sonnet model, so third- party Anthropic providers could fail the test while chat still worked. Resolve the test payload as explicit default → mapped Sonnet → server fallback, and only pre-fill modelName when the preset exposes the model_names field (preserving MiMo #577A). Related: op7418#461
|
Someone is attempting to deploy a commit to the op7418's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
area:ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sonnet.modelNamefromdefaultModelId, so that alias cannot override the Sonnet mapping in the test payload.model_names(for example MiMo) still pre-fill the editable model field, preserving #577A behavior.Root cause
PresetConnectDialogonly sent a singlemodelNameon connection test. Create-mode pre-fill wrotepreset.defaultModelId(often the catalog aliassonnet) into that field even when the field was not shown. Users who only filled Sonnet mapping therefore still probed withmodel: "sonnet", while chat could already use the mapped upstream id.Why not only #575
Open PR #575 also tries to prefer role mappings, but if the hidden default still pre-fills
modelNamewithsonnet, that value wins beforemapSonnet. This PR closes that gap with a narrower change and without the 503 classifier expansion.Verification
v22.23.2)npx tsc --noEmit— passprovider-connection-test-model,mimo-model-mapping,provider-key-lifecycle,provider-preset— 144 pass / 0 failnative-timeout-reasons.test.ts): 4507 pass / 11 failprovider-request-shapeAnthropic tests polluted by a local default endpoint (ark.cn-beijing.volces.com), unrelated to this patchRelated
Related: #461